Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Aug 8, 2025

Closes WOOMOB-965

Description

This PR updates tracking for the Jetpack Setup as suggested in p91TBi-d1G-p2, the changes are:

  • Introduces a new property connection_type with a value of either native or web depending on whether Connection API is supported or not.
  • Removes all login_jetpack_setup_* events and instead tracks a new property is_using_application_password to differentiate the flows.
  • Updates unit tests for tracking

Testing steps

  • Start Jetpack Setup.
  • Check the Xcode console log for the Tracked entries. If you run the app from an alpha build, check for events in Tracks live view.
  • Confirm that all jetpack_setup_flow events are tracked with correct properties.

Testing information

Tested with application password and cookie nonce flows, native and web connection flows.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.1 milestone Aug 8, 2025
@itsmeichigo itsmeichigo added type: task An internally driven task. category: tracks Related to analytics, including Tracks Events. labels Aug 8, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Aug 8, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 8, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15999-14d3f01
Version23.0
Bundle IDcom.automattic.alpha.woocommerce
Commit14d3f01
Installation URL6evd06o16r6r8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Base automatically changed from woomob-965-jetpack-connection-update to trunk August 11, 2025 08:27
@itsmeichigo itsmeichigo marked this pull request as ready for review August 12, 2025 03:46
@hichamboushaba hichamboushaba self-assigned this Aug 12, 2025
Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, nice work @itsmeichigo :shipit:

@hichamboushaba hichamboushaba merged commit deb7e6b into trunk Aug 12, 2025
16 checks passed
@hichamboushaba hichamboushaba deleted the woomob-965-tracking branch August 12, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants